Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/757?usp=email )
Change subject: event/multi: add event_arg object to make event handling more generic ...................................................................... Patch Set 1: Code-Review-1 (6 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/757/comment/d285fad6_adb4db9c : PS1, Line 11: distinguish which of these sockets have been pocked by an incoming poked? http://gerrit.openvpn.net/c/openvpn/+/757/comment/8fd531fb_1f14a455 : PS1, Line 15: event handler argument, from a "partly integer evaluated variable" "integer-evaluated" would be easier to parse I think. http://gerrit.openvpn.net/c/openvpn/+/757/comment/e6c649bc_aca2f81f : PS1, Line 22: use only one socket to handle all clients i/o. Sounds clunky, "I/O of all clients" maybe? Or just "all clients." Patchset: PS1: Documentation review. Please also note the "Uncrustify" failure. File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/f0c63fc8_4797f681 : PS1, Line 105: struct event_arg ev_arg; Please add documentation What is the advantage of storing this in the mi itself? Memory handling? File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/91cb60e0_7934e9e5 : PS1, Line 169: struct event_arg ev_arg; Please add documentation -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icd7f6a2ad350cdc2312b3e80fa0dbdd7e4311d2e Gerrit-Change-Number: 757 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 25 Sep 2024 09:51:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
