Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/757?usp=email )
Change subject: event/multi: add event_arg object to make event handling more generic ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File src/openvpn/mtcp.c: http://gerrit.openvpn.net/c/openvpn/+/757/comment/5bf1ba01_bbec3305 : PS2, Line 758: MTCP_SOCKET Shouldn't this "else if" part be removed? Or is there still some way left how this could be true? Doesn't look to me like it could, File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/ba0426ba_82f1a738 : PS2, Line 106: struct event_arg ev_arg; /* this struct will store a pointer to either mi or I think new comments should use doxygen formatting. See e.g. "time_t created" below. File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/74f701ee_1213a009 : PS2, Line 181: struct I think new comments should use doxygen formatting. File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/8f74e8f6_5f1dbc35 : PS1, Line 169: struct event_arg ev_arg; > explained in previous reply. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icd7f6a2ad350cdc2312b3e80fa0dbdd7e4311d2e Gerrit-Change-Number: 757 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 02 Oct 2024 11:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
