Attention is currently required from: flichtenheld, plaisthos.

its_Giaan has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/757?usp=email )

Change subject: event/multi: add event_arg object to make event handling more 
generic
......................................................................


Patch Set 4:

(3 comments)

File src/openvpn/mtcp.c:

http://gerrit.openvpn.net/c/openvpn/+/757/comment/bd54e635_fd461c9e :
PS3, Line 694: *
> any reason to define this before the if?
Done


File src/openvpn/multi.h:

http://gerrit.openvpn.net/c/openvpn/+/757/comment/c4f2855b_6b8fd60b :
PS3, Line 106: this
> Forgot "<" so this comment applies to gc
Done


File src/openvpn/socket.h:

http://gerrit.openvpn.net/c/openvpn/+/757/comment/726a0fd2_373da8b1 :
PS3, Line 181:     struct event_arg ev_arg;   /** this struct will store a 
pointer to either mi or
> Forgot "<" so this comment applies to sd
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icd7f6a2ad350cdc2312b3e80fa0dbdd7e4311d2e
Gerrit-Change-Number: 757
Gerrit-PatchSet: 4
Gerrit-Owner: its_Giaan <gianma...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: ordex <a...@unstable.cc>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Fri, 11 Oct 2024 14:08:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to