Attention is currently required from: its_Giaan, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/757?usp=email )
Change subject: event/multi: add event_arg object to make event handling more generic ...................................................................... Patch Set 1: (1 comment) File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/757/comment/3b5bb7d4_ed938931 : PS1, Line 105: struct event_arg ev_arg; > With the current approach we pass &mi as data to the event engine, because if > data is an address we […] Thanks for the explanation. Maybe we can add an abbreviated version of that as a comment here? How about "pointer to ourselves for purposes of passing it as event data"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/757?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icd7f6a2ad350cdc2312b3e80fa0dbdd7e4311d2e Gerrit-Change-Number: 757 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 25 Sep 2024 11:53:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel