Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email )
Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ...................................................................... Patch Set 11: Code-Review-1 (3 comments) Patchset: PS11: the dco.c string fix was overlooked, the rest is ready to be merged now (not sure why the builds fail in t_server_null) File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/9fcc0c82_242360d5 : PS10, Line 306: return false; > Done Umm. This does not look changed between 10 and 11? I saw a similar code fragment changed in a different patch, but not here... File src/openvpn/tun_afunix.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/42b0e935_ab5748b8 : PS10, Line 125: > I am not sure that waiting is really needed. We could wait to ensure that the > child really exits. […] ignoring SIGCHLD is good enough -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I65099ef00822d08fd3f5480c80892f3bf86c56e7 Gerrit-Change-Number: 747 Gerrit-PatchSet: 11 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 24 Sep 2024 10:42:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org> Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
