Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email )
Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ...................................................................... Patch Set 10: (7 comments) File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/dc90dae1_5d368c9f : PS10, Line 306: return false; > blank missing, and I would not wrap a single word Done File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/786d9bf0_01d92300 : PS10, Line 1325: c->c2.buf.len = tun_afunix_read(c->c1.tuntap, BPTR(&c->c2.buf), c->c2.frame.buf.payload_size); > the monk in me complains that `read_tun()` should be paired with > `read_tun_afunix()`... […] Done http://gerrit.openvpn.net/c/openvpn/+/747/comment/4985ee6c_466dd8db : PS10, Line 1939: size = tun_afunix_write(c->c1.tuntap, BPTR(&c->c2.to_tun), BLEN(&c->c2.to_tun)); > see above ;-) Done File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/9d2a0551_4486932b : PS10, Line 2060: tun_afunix_close(c->c1.tuntap); > you are using `open_tun_afunix()` for `open_tun()`, so this really should be > `close_tun_afunix()` th […] Done File src/openvpn/run_command.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/128d3fd4_13147565 : PS10, Line 52: #define S_NOWAITPID (1<<3) > the indenting here looks like one is using tab, one is using spaces Done File src/openvpn/tun_afunix.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/56f93adc_cb7474df : PS10, Line 39: #if defined(AF_UNIX) && !defined(WIN32) > I do wonder if the conditional on `AF_UNIX` is really needed (here and > elsewhere). […] Done http://gerrit.openvpn.net/c/openvpn/+/747/comment/11503245_d6c4ddaf : PS10, Line 125: > should we `wait()`? Or are we handling SIGCHLD elsewhere? I am not sure that waiting is really needed. We could wait to ensure that the child really exits. We currently ignore SIGCHLD and that means that the process will just die. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I65099ef00822d08fd3f5480c80892f3bf86c56e7 Gerrit-Change-Number: 747 Gerrit-PatchSet: 10 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 24 Sep 2024 08:21:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
