Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email )
Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ...................................................................... Patch Set 6: (11 comments) File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/747/comment/b63d509d_2a0f71c0 : PS1, Line 19: ``dev-node:/path/to/lwipovpn`` can emulate a full client that > Shouldn't that be "unix:" ? Acknowledged http://gerrit.openvpn.net/c/openvpn/+/747/comment/3afc6112_dfb74e8e : PS1, Line 20: can be pinged, can server a website and more without requiring any > "serve" Acknowledged File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/747/comment/dbeb5e05_fce150de : PS1, Line 123: will pass the tun configuration as environment variables. > ". […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/747/comment/b77c1645_98184cf9 : PS1, Line 124: The temporary unix will be be passed in the environment variable > "unix domain socket" ? Acknowledged File src/openvpn/run_command.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/25287472_63072ada : PS1, Line 50: /** instead of waiting for child process exist status return the > "exist" -> "exit"? Acknowledged File src/openvpn/run_command.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/ec7cc4f3_75a1d08b : PS1, Line 196: openvpn_execve > Aren't there changes missing to openvpn_execve in this patch? Yes. They should be now there in the current. version File src/openvpn/ssl.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/67544632_76ef8bbc : PS1, Line 222: \ > Spurious change? Acknowledged File src/openvpn/tun.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/fcd22e1e_00ef5a87 : PS1, Line 54: * this is always defined. We error out if a user tries to open this type > ". […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/747/comment/76c790a0_ec4dad57 : PS1, Line 55: * on unsupported platforms*/ > "platforms. […] Acknowledged File src/openvpn/tun_afunix.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/f537515b_57d9a083 : PS1, Line 32: * the user provided to that will take care of implementing the actual tun > Superfluous "to"? Acknowledged http://gerrit.openvpn.net/c/openvpn/+/747/comment/1841cd16_fe4cde55 : PS1, Line 33: * device > Missing full stop ". […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I65099ef00822d08fd3f5480c80892f3bf86c56e7 Gerrit-Change-Number: 747 Gerrit-PatchSet: 6 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 17 Sep 2024 16:31:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
