Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email )
Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ...................................................................... Patch Set 10: Code-Review-1 (8 comments) Patchset: PS10: I haven't seen any hard show-stopper, but a few minor nags... File src/openvpn/dco.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/df7a0350_ee091375 : PS10, Line 306: return false; blank missing, and I would not wrap a single word File src/openvpn/forward.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/f9ab8f69_a3d074cf : PS10, Line 1325: c->c2.buf.len = tun_afunix_read(c->c1.tuntap, BPTR(&c->c2.buf), c->c2.frame.buf.payload_size); the monk in me complains that `read_tun()` should be paired with `read_tun_afunix()`... but that is minor http://gerrit.openvpn.net/c/openvpn/+/747/comment/6ded27c5_58f53265 : PS10, Line 1939: size = tun_afunix_write(c->c1.tuntap, BPTR(&c->c2.to_tun), BLEN(&c->c2.to_tun)); see above ;-) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/57540e5b_f2836507 : PS10, Line 2060: tun_afunix_close(c->c1.tuntap); you are using `open_tun_afunix()` for `open_tun()`, so this really should be `close_tun_afunix()` then... File src/openvpn/run_command.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/c06210e8_581e4f52 : PS10, Line 52: #define S_NOWAITPID (1<<3) the indenting here looks like one is using tab, one is using spaces File src/openvpn/tun_afunix.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/57db59bc_b1c8c8db : PS10, Line 39: #if defined(AF_UNIX) && !defined(WIN32) I do wonder if the conditional on `AF_UNIX` is really needed (here and elsewhere). All OSes we support have AF_UNIX sockets... http://gerrit.openvpn.net/c/openvpn/+/747/comment/50341699_b37fbb94 : PS10, Line 125: should we `wait()`? Or are we handling SIGCHLD elsewhere? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I65099ef00822d08fd3f5480c80892f3bf86c56e7 Gerrit-Change-Number: 747 Gerrit-PatchSet: 10 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 23 Sep 2024 15:18:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
