Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/747?usp=email )
Change subject: Introduce DRIVER_AFUNIX backend for use with lwipovpn ...................................................................... Patch Set 2: Code-Review-1 (12 comments) File Changes.rst: http://gerrit.openvpn.net/c/openvpn/+/747/comment/99476969_1d8d6408 : PS1, Line 19: ``dev-node:/path/to/lwipovpn`` can emulate a full client that Shouldn't that be "unix:" ? http://gerrit.openvpn.net/c/openvpn/+/747/comment/4595f086_fbf96ee6 : PS1, Line 20: can be pinged, can server a website and more without requiring any "serve" File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/747/comment/8717edec_dfc8d582 : PS1, Line 123: will pass the tun configuration as environment variables. ". It will pass" ? http://gerrit.openvpn.net/c/openvpn/+/747/comment/cd99d110_cddddeda : PS1, Line 124: The temporary unix will be be passed in the environment variable "unix domain socket" ? File src/openvpn/run_command.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/7a11ae03_196cec21 : PS1, Line 50: /** instead of waiting for child process exist status return the "exist" -> "exit"? File src/openvpn/run_command.c: http://gerrit.openvpn.net/c/openvpn/+/747/comment/3b124102_8e33ed47 : PS1, Line 196: openvpn_execve Aren't there changes missing to openvpn_execve in this patch? File src/openvpn/ssl.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/d01d26be_8db826f8 : PS1, Line 222: \ Spurious change? File src/openvpn/tun.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/f4047f82_66d132b0 : PS1, Line 54: * this is always defined. We error out if a user tries to open this type ". This" http://gerrit.openvpn.net/c/openvpn/+/747/comment/99d6ccec_0c9c6678 : PS1, Line 55: * on unsupported platforms*/ "platforms. " File src/openvpn/tun_afunix.h: http://gerrit.openvpn.net/c/openvpn/+/747/comment/89a22cf1_1fdfde67 : PS1, Line 32: * the user provided to that will take care of implementing the actual tun Superfluous "to"? http://gerrit.openvpn.net/c/openvpn/+/747/comment/7325e601_60f01d40 : PS1, Line 33: * device Missing full stop "." http://gerrit.openvpn.net/c/openvpn/+/747/comment/5cee7cb8_700a23b3 : PS1, Line 56: * Reads a packet from a AF_UNIX based tun devices "device" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/747?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I65099ef00822d08fd3f5480c80892f3bf86c56e7 Gerrit-Change-Number: 747 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 16 Sep 2024 15:10:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
