I see, let me add that file to Makefile.am. My modified build system does not 
create the dist tarball :-(

 

Best,

Fish

 

From: Selva Nair [mailto:selva.n...@gmail.com] 
Sent: Monday, December 14, 2015 9:01 AM
To: Fish <fish.t...@gmail.com>
Cc: openvpn-devel@lists.sourceforge.net
Subject: Re: [PATCH] Make "block-outside-dns" option platform agnostic

 

Hi,

On Sun, Dec 13, 2015 at 8:25 PM, Fish <fish.t...@gmail.com 
<mailto:fish.t...@gmail.com> > wrote:

Make the "block-outside-dns" option agnostic of Windows versions by dynamically
loading WFP-related functions. Cross-compiled on Linux and tested on Windows
XP/10.
---
 src/openvpn/Makefile.am |   2 +-
 src/openvpn/init.c      |   4 -
 src/openvpn/options.c   |  17 ++-
 src/openvpn/win32.c     | 114 ++++++++-------
 src/openvpn/win32.h     |   1 +
 src/openvpn/win32_wfp.h | 359 ++++++++++++++++++++++++++++++++++++++++++++++++

 

Looks good, including the attribution to the right mingw upstream..

But won't build, as the new header (win32_wfp.h) is not added to 
src/openvpn/Makefile.am --- without that it wont get into the 
dist tarball etc..

Next time please append a version number to the mail header: 
something like [PATCH v2] would do. I'm getting confused with 
too many versions :)

 

Thanks,

Selva

 

 

Reply via email to