Hi,

On Sun, Dec 13, 2015 at 05:06:27PM -0800, Fish wrote:
Make the "block-outside-dns" option agnostic of Windows versions by dynamically
loading WFP-related functions. Cross-compiled on Linux and tested on Windows
XP/10.
---
  src/openvpn/Makefile.am |   2 +-
  src/openvpn/init.c      |   4 -
  src/openvpn/options.c   |  17 ++-
  src/openvpn/win32.c     | 114 ++++++++-------
  src/openvpn/win32.h     |   1 +
  src/openvpn/win32_wfp.h | 361 ++++++++++++++++++++++++++++++++++++++++++++++++

This layout of "all the copied API bits go to win32_wfp.h" is good enough
for me (so, mails crossed here).  Thanks.

I leave the final decision on "how do we want 2.3 binaries to look like"
(single openvpn binary with copied-API bits or xp-binary and vista+ binary)
to the windows team.  Both would work for me.

The build team (=me) would definitely prefer a single binary. Building separate binaries would be lots of hassle. I can give this patch a feature-ACK - can't comment on the code quality due to lack of C-fu. I also don't have a Windows XP to test this on.

--
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock

Reply via email to