Yicong-Huang commented on code in PR #8096: URL: https://github.com/apache/texera/pull/8096#discussion_r3922361837
########## .github/workflows/backport-approval-check.yml: ########## @@ -0,0 +1,334 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Blocks the merge while a `release/*` label on the PR has not been approved by +# that branch's release manager (.github/release-branches.yml). +# +# The point is that a merged PR's labels should be a truthful record. A label +# only nominates a branch, so before this check a manager declined a backport by +# staying silent — and the label stayed on, which read afterwards as "this +# shipped in 1.2" when it had not. Here declining is an action: the manager +# either approves, or removes their label. Since the merge waits for every +# remaining label to be approved, the labels on a merged PR are exactly the +# branches Direct Backport Push then sends the fix to. +# +# The author's job is to ask the manager for that call, not to make it for them. +# Editing labels needs triage access, so outside contributors and Renovate or +# Dependabot PRs cannot remove a label themselves — the failure report says so +# and names who to ask. +# +# `Backport Approvals` is listed in .asf.yaml's required_status_checks, so this +# job must produce a result on EVERY pull request, or a PR that never runs it +# waits forever. That is why it is not conditioned on the title, the labels, or +# the base branch: it always runs and reports success when there is nothing to +# approve. Merge groups are re-evaluated rather than waved through, because a +# queued PR's own checks are no longer consulted once it is queued; a group +# whose PRs cannot be resolved fails closed rather than passing unchecked. Do +# not rename the job — its display name is the required context. + +name: Backport Approval Check + +on: + pull_request: + types: + - opened + - reopened + - synchronize + - labeled + - unlabeled + # Retargeting arrives as `edited`, and the verdict depends on the base + # branch: a backport PR into release/* has nothing to approve, the same + # PR moved onto main does. + - edited + pull_request_review: + types: + - submitted + - dismissed + merge_group: + +# Read-only: this job never writes to the PR, and `pull_request_review` runs +# with the base repository's token even for fork PRs. +permissions: + contents: read + pull-requests: read + +concurrency: + group: backport-approvals-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + backport-approvals: + # Do not rename — this display name is the required status check context + # referenced in .asf.yaml. + name: Backport Approvals + runs-on: ubuntu-latest + steps: + # The base, not the PR head: the head can be arbitrarily old, and neither + # release-branches.yml nor its parser existed before #6941 — a head from + # before that (37 of the open PRs into main as of writing) would fail the + # `run:` step below with a file-not-found and turn this required check red + # with no way for the author to clear it. The base also keeps this reading + # the same config as the two other consumers: backport-auto-label.yml pins + # `base.sha`, and Direct Backport Push reads main after the merge. + # + # The trade-off is that a PR editing release-branches.yml is judged by the + # pre-edit config. Those are `ci:`-typed and carry no `release/*` labels, + # so there is nothing for the stale config to misjudge. + - name: Checkout + uses: actions/checkout@v7 + with: + ref: ${{ github.event.pull_request.base.sha || github.event.merge_group.head_sha }} Review Comment: `base.sha` is main's tip at this PR's **last synchronize**, not now. For any PR nobody has pushed to since #6941 landed, it predates `release_branches.py`, so `:99` exits 2 under `bash -eo pipefail`. That is 33 of the 221 open PRs into `main`. On each, the first label or review event turns this required check red with a file-not-found that no approval or unlabel can clear. `backport-auto-label.yml:78` pins the same ref and already fails this way in run 31542186218. Reading the default branch also closes a second hole. The config 404s on `release/v1.1` and `release/v1.2`, so a retarget onto one of them dies at `:99` before your `:288` message can print. `direct-backport-push.yml:42-45` already reads main this way. ```suggestion ref: ${{ github.event.repository.default_branch }} ``` ########## .github/workflows/backport-approval-check.yml: ########## @@ -0,0 +1,334 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# Blocks the merge while a `release/*` label on the PR has not been approved by +# that branch's release manager (.github/release-branches.yml). +# +# The point is that a merged PR's labels should be a truthful record. A label +# only nominates a branch, so before this check a manager declined a backport by +# staying silent — and the label stayed on, which read afterwards as "this +# shipped in 1.2" when it had not. Here declining is an action: the manager +# either approves, or removes their label. Since the merge waits for every +# remaining label to be approved, the labels on a merged PR are exactly the +# branches Direct Backport Push then sends the fix to. +# +# The author's job is to ask the manager for that call, not to make it for them. +# Editing labels needs triage access, so outside contributors and Renovate or +# Dependabot PRs cannot remove a label themselves — the failure report says so +# and names who to ask. +# +# `Backport Approvals` is listed in .asf.yaml's required_status_checks, so this +# job must produce a result on EVERY pull request, or a PR that never runs it +# waits forever. That is why it is not conditioned on the title, the labels, or +# the base branch: it always runs and reports success when there is nothing to +# approve. Merge groups are re-evaluated rather than waved through, because a Review Comment: The instruction is right but its stated reason no longer is. Since the context moved into the `~DEFAULT_BRANCH`-only ruleset (`.asf.yaml:122-125`), a PR into `release/*` is not waiting on it. The real reason not to condition on the base is different: there is nothing to approve there. ```suggestion # `Backport Approvals` is a required status check on the default branch # (.asf.yaml), so this job must produce a result on every pull request into # `main`, or a PR that never runs it waits forever. That is why it is not # conditioned on the title or the labels. It is not conditioned on the base # branch either, for a different reason: a PR already targeting a release # branch is itself a backport, so the check reports success there. # Merge groups are re-evaluated rather than waved through, because a ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
