mengw15 commented on PR #8096: URL: https://github.com/apache/texera/pull/8096#issuecomment-5521553971
All of it addressed in `1273f493e`, replies on the threads. Both new must-fixes were mine and both were verified before fixing rather than taken on the description — the head-vs-base one especially: I moved that off `base.sha` last round on an argument that priced the security question correctly and the staleness question not at all. On the two conventions items: **Proof run.** You were right that the linked run took the zero-target early return, so `decide`'s blocked path had never executed. It has now, on this PR, using the sequence you suggested: | | run | result | | --- | --- | --- | | labelled `release/v1.2`, unapproved | [33723336875](https://github.com/apache/texera/actions/runs/33723336875) | fails — `BLOCKED release/v1.2 — needs an approving review from @xuang7` | | label removed (the decline action) | [33723396801](https://github.com/apache/texera/actions/runs/33723396801) | passes | | no `release/*` label | [33722853310](https://github.com/apache/texera/actions/runs/33722853310) | passes — "nothing to approve" | That is the whole flow the description claims, executed rather than argued. All three are linked there now. **Rollout note.** Extended: the description now says that pull requests already open into `main` at the cutover show the context as "Expected" until some event triggers the workflow on them, alongside the release-branch scoping and the one-ruleset revert. The `precheck.yml:327-331` wording you flagged on the veto thread — that adding `no-backport-needed` mid-review is how you cancel a backport, now only half the action — I agree is real and belongs in its own change rather than here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
