mengw15 commented on PR #8096: URL: https://github.com/apache/texera/pull/8096#issuecomment-5519792461
Thanks — all four must-fix items are addressed in `77d573c1a`, each verified before fixing rather than taken on the description. Replies are on the two inline threads; the other three summary items: **Simplifications — `direct-backport-push.yml:41-42`**: no longer applicable. That file was dropped from this PR before your review: gating post-merge as well was considered and removed, because in the one window it could still cover — an approval dismissed after the merge group went green — refusing the push leaves the PR merged with a `release/v1.2` label and nothing on v1.2, which is the misleading record this change exists to remove. The diff is six files now and `skipped_entries` does not appear in it. **Conventions — no linked proof run**: added to the description. https://github.com/apache/texera/actions/runs/33594961258 is `Backport Approvals` passing on this PR, reporting "No `release/*` labels — nothing to approve" — which is also the case that must never block, since the context is required on every PR. The harness that sliced JS out of the YAML is gone with the shared script; `pulls.listReviews` pagination does still first run in production, and the description says so. **Conventions — the `declined` and files-absent `skipped` rows**: fixed. Both now say the branch's release manager has to approve before the PR can merge, rather than implying the label alone causes the backport. The `actively-supporting` paragraph also now says that no review is requested for an inactive branch, so whoever adds its label by hand should ping the manager themselves — otherwise the merge blocks on someone who was never told. One loose end I could not act on: the summary opens with "4 must-fix · 3 advisory · **2 polish**" and closes with "Polish: 2 quick touch-ups (see the summary)", but the four sections list exactly the seven must-fix and advisory items and no polish ones. If those two were meant to be there, could you paste them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
