vedantprajapati commented on code in PR #33002:
URL: https://github.com/apache/superset/pull/33002#discussion_r2196072185
##########
superset-frontend/packages/superset-ui-core/src/components/Dropdown/index.tsx:
##########
@@ -110,8 +110,61 @@ export const NoAnimationDropdown = (props:
NoAnimationDropdownProps) => {
);
};
+const CustomDropdownButton = (props: ButtonProps & DropdownProps) => {
Review Comment:
> I think to be more vanilla, maybe not having the hover would be ok?
Looking at sql lab we have something similar with the save button and it's more
of a click than a hover. This tends to also make the arrow more aligned as it's
a caret than a triangle.
@sadpandajoe
Sure we can do that too, however similarly, it would just create another
unnecessary component. Allowing the base dropdown to support these options
makes a bit more sense to me and it works out of the box as long as we include
the correct props.
We're kind of just recreating a seperate component for this save carat and
the run buttons in sqllab
https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/SaveDatasetActionButton/index.tsx
By default the button can look like any of the following. If we're going
with base styles, the third one looks the best suited:
<img width="130" alt="image"
src="https://github.com/user-attachments/assets/c1191df8-f8df-48e1-a64c-e8fe40bf9045";
/>
Let me see if i can reduce the intrusiveness of my code in the dropdown
component
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
