mistercrunch commented on code in PR #33002:
URL: https://github.com/apache/superset/pull/33002#discussion_r2195802535
##########
superset-frontend/packages/superset-ui-core/src/components/Dropdown/index.tsx:
##########
@@ -110,8 +110,61 @@ export const NoAnimationDropdown = (props:
NoAnimationDropdownProps) => {
);
};
+const CustomDropdownButton = (props: ButtonProps & DropdownProps) => {
Review Comment:
> are we re-implementing
packages/superset-ui-core/src/components/DropdownButton/index.tsx
I'm thinking that if that's the case, there's some meta questions about
discoverability of existing components and developer docs. We really need to be
cautious around making sure that our design-system and component-lib is used
properly somehow.
Side note, but while working on the theming branch, I noticed that we have a
number of instances of places in the codebase that recreates/restyle buttons
for instance. I can totally see that it's easy to merge something like this,
and realize at some point we have 3-4 flavors of dropdown buttons ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
