mistercrunch commented on code in PR #33002:
URL: https://github.com/apache/superset/pull/33002#discussion_r2195796060
##########
superset-frontend/packages/superset-ui-core/src/components/Dropdown/index.tsx:
##########
@@ -110,8 +110,61 @@ export const NoAnimationDropdown = (props:
NoAnimationDropdownProps) => {
);
};
+const CustomDropdownButton = (props: ButtonProps & DropdownProps) => {
Review Comment:
Mmmh, not sure about this section - we're really trying to go vanilla on
antd as much as possible. Are we not affecting all other Dropdowns here? I'd
have to spend more time to really understand what's going on here. Digging a
tiny bit into it, are we re-implementing
packages/superset-ui-core/src/components/DropdownButton/index.tsx ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
