sadpandajoe commented on code in PR #33002:
URL: https://github.com/apache/superset/pull/33002#discussion_r2195900935
##########
superset-frontend/packages/superset-ui-core/src/components/Dropdown/index.tsx:
##########
@@ -110,8 +110,61 @@ export const NoAnimationDropdown = (props:
NoAnimationDropdownProps) => {
);
};
+const CustomDropdownButton = (props: ButtonProps & DropdownProps) => {
Review Comment:
I think to be more vanilla, maybe not having the hover would be ok? Looking
at sql lab we have something similar with the save button and it's more of a
click than a hover. This tends to also make the arrow more aligned as it's a
caret than a triangle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
