mistercrunch commented on code in PR #33002:
URL: https://github.com/apache/superset/pull/33002#discussion_r2196126829
##########
superset-frontend/packages/superset-ui-core/src/components/Dropdown/index.tsx:
##########
@@ -110,8 +110,61 @@ export const NoAnimationDropdown = (props:
NoAnimationDropdownProps) => {
);
};
+const CustomDropdownButton = (props: ButtonProps & DropdownProps) => {
Review Comment:
nice! these little adjustments on the component lib is how we get back on
track! Guessing `DropdownButton` should align with our `Button` component which
is a pretty mutated version of the native antd, with its own props like
`buttonStyle`, `buttonSize`, ... There's probably more simplification needed on
that component to realign it to antd-v5, but we'll save that for another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
