mistercrunch commented on code in PR #31590:
URL: https://github.com/apache/superset/pull/31590#discussion_r1968737573
##########
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberViz.tsx:
##########
@@ -374,7 +374,7 @@ export default styled(BigNumberVis)`
.kicker,
.header-line,
.subheader-line {
- opacity: ${theme.opacity.mediumHeavy};
+ opacity: 60%;
Review Comment:
oh that was a bit of a hard slash (machete in the jungle), here's the
rationale for slashing/hard-coding it:
- The antd theming system doesn't specify presets for opacity, probably
because there's no clear aligned standards or design guidelines to follow here.
Case-by-case might be better
- use/reuse across the codebase was minimal, with hard-coded widespread,
token reuse not common
- is there real value around having set values? what should they be? does it
help to use midHeavy over 80% or 70%. Would a "themer" want to alter these
values centrally ,like "oh I want all the mediumHeavy to be a little lighter in
my environment"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
