mistercrunch commented on code in PR #31590:
URL: https://github.com/apache/superset/pull/31590#discussion_r1968712153
##########
superset-frontend/packages/superset-ui-chart-controls/src/components/SQLPopover.tsx:
##########
@@ -66,8 +66,8 @@ export const SQLPopover = (props: PopoverProps & {
sqlExpression: string }) => {
wrapEnabled
style={{
border: `1px solid ${theme.colors.grayscale.light2}`,
- background: theme.colors.secondary.light5,
- maxWidth: theme.gridUnit * 100,
+ background: theme.colorPrimaryBg,
+ maxWidth: theme.sizeUnit * 100,
Review Comment:
Yeah I think `sizeUnit` is best used for spacing (margin/padding), though
the thing to understand is that a `compact` mode would typically be achieved by
sizing down `sizeUnit`, so if you want your component size to grow/shrink with
everything else here you might want to use it or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
