kgabryje commented on PR #31590: URL: https://github.com/apache/superset/pull/31590#issuecomment-2679256675
A few visual bugs that I found while testing: 1. Weird background behind dropdown triggers (home page, dashboard) <img width="1723" alt="image" src="https://github.com/user-attachments/assets/77cccc51-9f35-4f74-9ee0-57d0e5245dc2"; /> 2. 2 primary buttons in edit dashboard modal (and many other places) <img width="907" alt="image" src="https://github.com/user-attachments/assets/0d072756-fff9-4e0b-9534-f0d9f570af1d"; /> 3. Nit but we probably should have a tooltip or an icon in the light/dark trigger 4. Gray background behind the native filters bar looks kinda weird. Also, the full tab content background should probably be white, and it's gray (on the right of the deckgl chart) <img width="1728" alt="image" src="https://github.com/user-attachments/assets/15c3a1c0-0b0c-4adb-bf83-c40e99239628"; /> 5. The background behind the copy button is kinda strong <img width="940" alt="image" src="https://github.com/user-attachments/assets/ada05c56-0cdd-492d-95f6-93042b9e42f7"; /> 6. Gray background behind the pagination component. Also, the edit chart button doesnt look like our secondary buttons. The modal header and table header are white, and they were gray before, not sure if that's intentional. Side note - the border radius seems to be bigger than before, is that intentional? <img width="917" alt="image" src="https://github.com/user-attachments/assets/323a3588-f378-4e5c-9aae-8f7ca20c038f"; /> 7. Submenu looks like it's behind the menu instead of in front of it. That however might be related to the recent antd5 migration because I'm seeing the same thing on master <img width="539" alt="image" src="https://github.com/user-attachments/assets/313440e3-7302-4234-8f0c-5d18108cdfd4"; /> 8. The tooltips are more transparent and they're a bit hard to read when on top of some text <img width="458" alt="image" src="https://github.com/user-attachments/assets/1ed0b9c5-e7ba-404e-9632-4d2db0046e94"; /> 9. Discard button should be secondary in edit mode, the right panel was white before (I think it looked better) 10. Gray background behind the update chart button in Explore - is that intentional? Also, the colors in the controls are a bit strong and overwhelming, they were lighter gray before and I think they looked better <img width="391" alt="image" src="https://github.com/user-attachments/assets/970fd7d3-6340-4dd3-89ad-fd092731a2eb"; /> 11. 3 primary buttons in Save chart modal <img width="689" alt="image" src="https://github.com/user-attachments/assets/e68052f6-cb07-48eb-bfde-34c7fa93e682"; /> 12. Some controls are unreadable in dark mode <img width="703" alt="image" src="https://github.com/user-attachments/assets/3f9615e6-4fe9-47f6-bf61-7f80943bb39f"; /> 13. maybe we should make the border color lighter? It looks kinda overwhelming in many places, like here in viz type selector <img width="1093" alt="image" src="https://github.com/user-attachments/assets/57999f07-de94-478d-9bd0-df01ac9c1553"; /> 14. Lots of primary buttons in sql lab, also the ag grid table theme looks a bit different? Filter input looks like its disabled, but its not <img width="1728" alt="image" src="https://github.com/user-attachments/assets/3ecf8c51-8125-4c1d-955c-e1a6e6af4935"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
