kgabryje commented on PR #31590: URL: https://github.com/apache/superset/pull/31590#issuecomment-2697061168
Looks much better already! I've got some second pass comments: ### Dashboard list page Before: <img width="1728" alt="image" src="https://github.com/user-attachments/assets/44f7502f-2c75-43fd-bc7f-22bcaccc6ce3"; /> After: <img width="1728" alt="image" src="https://github.com/user-attachments/assets/9fe94ff8-d4be-4f9c-bd2f-b0298eae13c5"; /> 1. Secondary button looks different 2. Buttons have larger border radius than before 3. Spacing between the header and the filters section is smaller 4. Import dashboards icon has different color 5. Filters placeholders were light grey before 6. When you click on a filter, the active option in the menu has darker color than before ### Dashboard 1. Native filters bar has gray background instead of white 2. The gray background behind the metadata bar is gone 3. Font size of the dashboard header is smaller 4. Table chart looks a bit different - now the header is gray, and before every other row had a light gray background, now its all white 5. Native filters modal - spacings are a bit off, the settings/scoping tabs background is gray 6. In edit mode, the right panel has gray background, and "create new chart" button has different color 7. Discard button is primary, should be secondary ### Explore 1. Borders is controls are much darker 2. Gray background behind Update Chart button 3. In table chart, when I applied conditional formatting, the colors are much lighter (more transparent??) than before -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
