mistercrunch commented on PR #31590:
URL: https://github.com/apache/superset/pull/31590#issuecomment-2698916831

   ### Dashboard list page
   
   > Secondary button looks different
   
   Trying to address this with secondary="filled" with color="primary" instead 
of "outlined" / "grayscale"
   
   > Buttons have larger border radius than before
   
   Going vanilla! We could reduce it if we want to maintain consistency with 
previous theme for this specifically
   
   > Spacing between the header and the filters section is smaller
   
   TODO
   
   > Import dashboards icon has different color
   TODO: I'm a bit puzzled by this one 
   
   > Filters placeholders were light grey before
   
   Should fix itself as we migrate Form to antd-v5
   
   > When you click on a filter, the active option in the menu has darker color 
than before
   
   Should fix itself as migrate Select to antd-v5
   
   ### Dashboard
   > Native filters bar has gray background instead of white
   
   Fixed!
   
   > The gray background behind the metadata bar is gone
   
   Fixed, using `colorLayout` instead of colorBgElevated, which is white in the 
theme
   
   > Font size of the dashboard header is smaller
   looks like it's 20px now
   
   > Table chart looks a bit different - now the header is gray, and before 
every other row had a light gray background, now its all white
   
   TODO
   
   > Native filters modal - spacings are a bit off, the settings/scoping tabs 
background is gray
   
   TODO
   
   > In edit mode, the right panel has gray background, and "create new chart" 
button has different color
   Fixed!
   
   > Discard button is primary, should be secondary
   
   Fixed!
   
   ### Explore
   > Borders is controls are much darker
   
   mmmh is that for large Selects? Like the box containing the things in the 
select?
   
   > Gray background behind Update Chart button
   fixed! (I think...)
   
   > In table chart, when I applied conditional formatting, the colors are much 
lighter (more transparent??) than before
   
   TODO


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to