AMashenkov commented on code in PR #5218:
URL: https://github.com/apache/ignite-3/pull/5218#discussion_r1957970941
##########
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java:
##########
@@ -57,43 +52,78 @@ public static String parseSimpleName(String name) {
}
/**
- * Creates a fully qualified name in canonical form, that is, enclosing
each part of the identifier chain in double quotes.
+ * Parses fully qualified name.
*
- * @param schemaName Name of the schema.
- * @param objectName Name of the object.
- * @return Returns fully qualified name in canonical form.
+ * @param name Fully qualified name of the object in canonical form.
+ * @return List of identifiers, where each identifier within the full name
chain will be either unquoted or converted to uppercase.
*/
- // TODO https://issues.apache.org/jira/browse/IGNITE-24021: replace
`quote` call with `quoteIfNeeded`
- @Deprecated(forRemoval = true)
- public static String canonicalName(String schemaName, String objectName) {
- return quote(schemaName) + '.' + quote(objectName);
+ public static List<String> parseName(String name) {
+ ensureNotNullAndNotEmpty(name, "name");
+
+ List<String> identifiers = new ArrayList<>();
Review Comment:
```suggestion
List<String> identifiers = new ArrayList<>(2);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
