xtern commented on code in PR #5218:
URL: https://github.com/apache/ignite-3/pull/5218#discussion_r1955744585
##########
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java:
##########
@@ -38,8 +37,6 @@ private IgniteNameUtils() {
* @param name String to parse object name.
* @return Unquoted name or name is cast to upper case. "tbl0" ->
"TBL0", "\"Tbl0\"" -> "Tbl0".
*/
- // TODO https://issues.apache.org/jira/browse/IGNITE-24021: Use
QualifiedName instead.
- @Deprecated(forRemoval = true)
public static String parseSimpleName(String name) {
Review Comment:
This comment conflicts with another TODO
```
// TODO: https://issues.apache.org/jira/browse/IGNITE-24021
// Replace this with using correct implementation of
`IgniteNameUtils.parseSimpleName`, when it will be fixed.
String schemaNameInCanonicalForm =
QualifiedName.fromSimple(defaultSchemaName).objectName();
```
Also
```
QualifiedName.fromSimple(defaultSchemaName).objectName();
```
looks weird and a bit confusing, considering that we are passing the name of
the schema, but getting object name (not schema name)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
