xtern commented on code in PR #5218:
URL: https://github.com/apache/ignite-3/pull/5218#discussion_r1955893526
##########
modules/api/src/test/java/org/apache/ignite/table/QualifiedNameTest.java:
##########
@@ -273,9 +270,4 @@ public void malformedCanonicalNames(String source) {
containsString("Malformed identifier [identifier=" + source)
)));
}
-
- // TODO https://issues.apache.org/jira/browse/IGNITE-24021 Move to
IgniteNameUtils
- private static String canonicalName(String schemaName, String objectName) {
- return schemaName == null ? quoteIfNeeded(objectName) :
quoteIfNeeded(schemaName) + '.' + quoteIfNeeded(objectName);
Review Comment:
There is no reason to allow `null` for `schemaName`. We using
`quoteIfNeeded` instead.
Alternatively we can change method signature to
```
canonicalName(String ... names)
```
and replace quoteIfNeeded(name) with canonicalName(name) everywhere.... thus
making `quoteIfNeeded` private :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
