lowka commented on code in PR #5218:
URL: https://github.com/apache/ignite-3/pull/5218#discussion_r1956234113
##########
modules/api/src/main/java/org/apache/ignite/table/QualifiedName.java:
##########
@@ -107,15 +108,34 @@ public static QualifiedName fromSimple(String simpleName)
{
* @return Qualified name.
*/
public static QualifiedName of(@Nullable String schemaName, String
objectName) {
- String schemaIdentifier = schemaName == null ? DEFAULT_SCHEMA_NAME :
parseIdentifier(schemaName);
- String objectIdentifier = parseIdentifier(objectName);
+ if (schemaName == null) {
+ schemaName = DEFAULT_SCHEMA_NAME;
+ }
- verifySchemaIdentifier(schemaIdentifier);
- verifyObjectIdentifier(objectIdentifier);
+ verifyObjectIdentifier(objectName);
+ verifySchemaIdentifier(schemaName);
+
+ String schemaIdentifier = parseSimpleName(schemaName);
+ String objectIdentifier = parseSimpleName(objectName);
return new QualifiedName(schemaIdentifier, objectIdentifier);
}
+ /**
+ * Return QualifiedName from a given schema and table normalized names.
+ *
+ * @param schemaName Normalized schema name or {@code null} for default
schema.
+ * @param objectName Normalized object name.
+ * @return Qualified name.
+ */
+ public static QualifiedName fromNormalized(@Nullable String schemaName,
String objectName) {
+ verifySchemaIdentifier(schemaName);
+ verifyObjectIdentifier(objectName);
+
+ return new QualifiedName(schemaName == null ? DEFAULT_SCHEMA_NAME :
schemaName, objectName);
+ }
+
+
Review Comment:
I think this empty line is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
