AMashenkov commented on code in PR #5218:
URL: https://github.com/apache/ignite-3/pull/5218#discussion_r1957984569
##########
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java:
##########
@@ -213,29 +222,44 @@ public boolean hasNext() {
// looks like we just found a closing quote
sb.append(source, start, currentPosition);
+ foundDot = hasNextChar();
currentPosition += 2;
return sb.toString();
}
- throwMalformedNameException();
- } else if (!quoted && (currentChar() == '.' || currentChar()
== ' ')) {
+ throwMalformedIdentifierException();
+ } else if (c == '.') {
+ if (quoted) {
+ continue;
+ }
+
sb.append(source, start, currentPosition);
currentPosition++;
+ foundDot = true;
return sb.toString().toUpperCase();
+ } else if (!quoted
+ &&
!identifierStart(source.codePointAt(currentPosition))
+ &&
!identifierExtend(source.codePointAt(currentPosition))
Review Comment:
Including alphabetic characters (`indentifierStart`) into `identifierExtend`
will make this code simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
