sanpwc commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1850899227
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaResult.java:
##########
@@ -17,28 +17,30 @@
package org.apache.ignite.internal.replicator;
-import java.util.concurrent.CompletableFuture;
import org.jetbrains.annotations.Nullable;
/**
* Represents replica execution result.
*/
public class ReplicaResult {
+ /** Default replication outcome result. */
+ private static final CommandApplicationResult DEFAULT_RESULT = new
CommandApplicationResult(null, null);
+
/** The result. */
private final Object res;
/** The replication future. */
- private final CompletableFuture<?> repFut;
+ private final CommandApplicationResult commandApplicationResult;
/**
* Construct a replica result.
*
* @param res The result.
- * @param repFut The replication future.
+ * @param commandApplicationResult The replication result.
*/
- public ReplicaResult(@Nullable Object res, @Nullable CompletableFuture<?>
repFut) {
+ public ReplicaResult(@Nullable Object res, @Nullable
CommandApplicationResult commandApplicationResult) {
this.res = res;
- this.repFut = repFut;
+ this.commandApplicationResult = commandApplicationResult == null ?
DEFAULT_RESULT : commandApplicationResult;
Review Comment:
Should we use ReplicaResult with single param in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
