sanpwc commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1850826640


##########
modules/raft/src/integrationTest/java/org/apache/ignite/raft/jraft/core/ItNodeTest.java:
##########
@@ -3815,82 +3811,6 @@ public void testLeaseReadAfterSegmentation() throws 
Exception {
         assertTrue(res.get().isOk());
     }
 
-    /**
-     * Tests propagation of HLC on heartbeat request and response.
-     */
-    @Test
-    public void testHlcPropagation() throws Exception {

Review Comment:
   You've left lot's of dead code. E.g. there's no longer need to provide 
HybridClock to Loza nor store it in NodeOptions. It's just an example. I guess 
there's more code to remove since we no longer need. Curious why it's not a 
dedicated PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to