ascherbakoff commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1852183049
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/TxManager.java:
##########
@@ -116,17 +116,16 @@ public interface TxManager extends IgniteComponent {
* Finishes a one-phase committed transaction. This method doesn't contain
any distributed communication.
*
* @param timestampTracker Observable timestamp tracker. This tracker is
used to track an observable timestamp and should be
- * updated with commit timestamp of every committed transaction.
+ * updated with commit timestamp of every committed transaction.
Not null on commit.
* @param txId Transaction id.
* @param commit {@code True} if a commit requested.
*/
- void finishFull(HybridTimestampTracker timestampTracker, UUID txId,
boolean commit);
+ void finishFull(HybridTimestampTracker timestampTracker, UUID txId,
@Nullable HybridTimestamp ts, boolean commit);
Review Comment:
🆗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
