sanpwc commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1850840311


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -2243,10 +2243,6 @@ public Message handleAppendEntriesRequest(final 
AppendEntriesRequest request, fi
                         .success(false)
                         .term(this.currTerm);
 
-                if (request.timestamp() != null) {

Review Comment:
   It would be nice to have detailed explanation why it's safe. It took some 
time for me to prove that it's true because of `tx1.commitTs < A.lease.endTime 
< B.lease.startTime < tx2.commitTs`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to