sanpwc commented on code in PR #4700:
URL: https://github.com/apache/ignite-3/pull/4700#discussion_r1850809258
##########
modules/core/src/main/java/org/apache/ignite/internal/util/PendingComparableValuesTracker.java:
##########
@@ -61,7 +62,7 @@ public class PendingComparableValuesTracker<T extends
Comparable<T>, R> implemen
private volatile boolean closeGuard;
/** Busy lock to close synchronously. */
- private final IgniteSpinBusyLock busyLock = new IgniteSpinBusyLock();
+ private final IgniteStripedReadWriteLock busyLock = new
IgniteStripedReadWriteLock();
Review Comment:
It violates a contract of a busyLock, it should not be possible to
"enterBusy" previously "blocked" lock, however it's possible to
busyLock.readLock.lock() after busyLock.wrireLock().lock().
PendingComparableValuesTracker class is an utility one, it's not valid to
expect that close and e.g. update will be called within different treads even
if it's true for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
