keith-turner commented on code in PR #5416:
URL: https://github.com/apache/accumulo/pull/5416#discussion_r2021845165
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -586,14 +594,9 @@ public void run() {
* the metadata table and remove any migrating tablets that no longer
exist.
*/
private void cleanupNonexistentMigrations(final ClientContext
clientContext) {
+ Map<DataLevel,Set<KeyExtent>> notSeen = partitionMigrations();
Review Comment:
>
tabletsMutator.mutateTablet(ke).putMigration(TabletServerIdImpl.toThrift(m.getNewTabletServer())).mutate();
(see Manager.balanceTablets for more context) is how migrations are added.
Does this meet this condition
That is an unconditional write to the metadata table. When the write runs
the tablet may no longer exists (tablet could have been merged away or the
tablet delete) but the write will still happen. That could lead to junk in the
metadata table that will make other parts of accumulo unhappy. Should use a
conditional write there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
