kevinrr888 commented on code in PR #5416:
URL: https://github.com/apache/accumulo/pull/5416#discussion_r2021451167


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -586,14 +594,9 @@ public void run() {
      * the metadata table and remove any migrating tablets that no longer 
exist.
      */
     private void cleanupNonexistentMigrations(final ClientContext 
clientContext) {
+      Map<DataLevel,Set<KeyExtent>> notSeen = partitionMigrations();

Review Comment:
   Removed, thanks for the added info. Wasn't sure if this method could be 
removed.
   
   > Migrations are added using a conditional mutation that checks tablet exists
   
   
`tabletsMutator.mutateTablet(ke).putMigration(TabletServerIdImpl.toThrift(m.getNewTabletServer())).mutate();`
 (see `Manager.balanceTablets` for more context) is how migrations are added. 
Does this meet this condition
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to