kevinrr888 commented on code in PR #5416:
URL: https://github.com/apache/accumulo/pull/5416#discussion_r2021427800
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -568,10 +573,13 @@ private class MigrationCleanupThread implements Runnable {
@Override
public void run() {
while (stillManager()) {
- if (!migrations.isEmpty()) {
+ // migrations are stored in the metadata tables which cannot be read
until the
+ // TabletGroupWatchers are started
+ if (watchersStarted.get() && numMigrations() > 0) {
Review Comment:
Good idea, moved.
My main point for this comment though was that I am not sure at what point
in the `TabletGroupWatcher.run` would metadata table scans be allowed. I don't
think this current impl of starting the migrations cleanup thread after the
tablet group watchers are started is entirely correct.
When I was writing this, found that metadata scans cannot occur until after
the tablet group watchers have been started, but should probably be waiting on
some condition in the `run` for tablet group watcher, I'm just not sure what.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
