kevinrr888 commented on code in PR #5416:
URL: https://github.com/apache/accumulo/pull/5416#discussion_r2023057732
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -586,14 +594,9 @@ public void run() {
* the metadata table and remove any migrating tablets that no longer
exist.
*/
private void cleanupNonexistentMigrations(final ClientContext
clientContext) {
+ Map<DataLevel,Set<KeyExtent>> notSeen = partitionMigrations();
Review Comment:
Okay, I wasn't sure if `mutateTablet(ke)` would ensure the tablet exists
before writing. I changed this to use a conditional mutation, but not sure if
it is right still:
`tabletsMutator.mutateTablet(ke).requireAbsentOperation()
.putMigration(TabletServerIdImpl.toThrift(m.getNewTabletServer()))
.submit(tm -> false);`
I did not see an existing method in `Ample.OperationRequirements` that
satisfies the check that the tablet exists. Should I add a new method like
`requirePresentTablet`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
