keith-turner commented on code in PR #5416:
URL: https://github.com/apache/accumulo/pull/5416#discussion_r2040099499
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -835,14 +833,15 @@ private void unassignDeadTablet(TabletLists tLists,
TabletMetadata tm) throws Wa
private void hostUnassignedTablet(TabletLists tLists, KeyExtent tablet,
UnassignedTablet unassignedTablet) {
// maybe it's a finishing migration
- TServerInstance dest = manager.migrations.get(tablet);
+ TServerInstance dest =
+ manager.getContext().getAmple().readTablet(tablet,
MIGRATION).getMigration();
if (dest != null) {
// if destination is still good, assign it
if (tLists.destinations.containsKey(dest)) {
tLists.assignments.add(new Assignment(tablet, dest,
unassignedTablet.getLastLocation()));
} else {
// get rid of this migration
- manager.migrations.remove(tablet);
+
manager.getContext().getAmple().mutateTablet(tablet).deleteMigration().mutate();
Review Comment:
This can probably be removed, will comment in more depth elsewhere.
Thinking when we set the future location that would be a natural place to
remove any migrations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
