Hi Dan,
Replies inline:
On 8/17/2011 1:17 PM, Dan Wendlandt wrote:
Hi Tyler,
Overall the structure looks great and this packaging is going to be a
big win for the project.
Is bzr handling the merges with trunk cleanly after files and
directories have been moved around? Otherwise, we'll have to think
carefully about how to merge this in.
No, bzr doesn't handle it well. That's why I need to wait for the rest
of the merges to go into Quantum, and then re-package it.
Seems like nova still keeps their run_tests.py and run_tests.sh in the
top dir. Might be useful to mimic that if this is what people
familiar with other OpenStack projects will expect (may make life
easier on the CI folks, which is always a good thing).
Sounds good.
I definitely agree with moving cli.py and batch_config.py to bin. We
should also probably add a quantum version of the preamble they use
for all of their file in /bin so that you do have to play games with
the PYTHONPATH when invoking them directly:
possible_topdir = os.path.normpath(os.path.join(os.path.abspath(
sys.argv[0]), os.pardir, os.pardir))
if os.path.exists(os.path.join(possible_topdir, "nova", "__init__.py")):
sys.path.insert(0, possible_topdir)
Alright, sounds great. I'll make these changes.
-Tyler
--
Mailing list: https://launchpad.net/~netstack
Post to : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp
