Hi Tyler,
Overall the structure looks great and this packaging is going to be a big
win for the project.
Is bzr handling the merges with trunk cleanly after files and directories
have been moved around? Otherwise, we'll have to think carefully about how
to merge this in.
A few minor comments inline.
Dan
On Mon, Aug 15, 2011 at 6:30 AM, Tyler Smith <tyles...@cisco.com> wrote:
> Thanks Salvatore,
>
> This is the kind of feedback I need. Putting tests in their respective
> packages makes sense, and should be trivial. As for your other proposals:
>
> 1) Sounds good. I wasn't sure what exactly to call it, so 'core' seemed
> like a good temporary name. I'll change it to 'quantum-server'.
>
> 2) I'll move those. Similarly, I was thinking about moving run_tests.py to
> bin/quantum_tests or something.
>
Seems like nova still keeps their run_tests.py and run_tests.sh in the top
dir. Might be useful to mimic that if this is what people familiar with
other OpenStack projects will expect (may make life easier on the CI folks,
which is always a good thing).
I definitely agree with moving cli.py and batch_config.py to bin. We should
also probably add a quantum version of the preamble they use for all of
their file in /bin so that you do have to play games with the PYTHONPATH
when invoking them directly:
possible_topdir = os.path.normpath(os.path.join(os.path.abspath(
sys.argv[0]), os.pardir, os.pardir))
if os.path.exists(os.path.join(possible_topdir, "nova", "__init__.py")):
sys.path.insert(0, possible_topdir)
>
> I'll update the blueprint and make the discussed changes. Before long I
> should have the 'quantum-server' packing fully working, and I'll send out an
> update, because at that point you should be able to completely install
> Quantum by package (I'll build some rpm binaries and include them in the
> repo).
>
> -Tyler
>
>
>
> On 8/12/2011 3:39 PM, Salvatore Orlando wrote:
>
>> Hi Tyler,
>>
>> Thanks for taking on the packaging work. The list of packages in your
>> proposal sounds good, I'm just not 100% sure whether we want tests in their
>> own packages or spread across the various packages, but I wouldn't mind if
>> we had a package specific for tests.
>>
>> I have two "additional" proposals:
>> 1) Since client tools are going into their own package, why don't we
>> rename core into "server"?
>> 2) Binaries: cli.py and batch_setup.py are client binaries IMHO. I'd
>> rather have them in a bin directory in the client package (they're currently
>> in /quantum).
>>
>> Regards,
>> Salvatore
>>
>
> --
> Mailing list:
> https://launchpad.net/~**netstack<https://launchpad.net/~netstack>
> Post to : netstack@lists.launchpad.net
> Unsubscribe :
> https://launchpad.net/~**netstack<https://launchpad.net/~netstack>
> More help :
> https://help.launchpad.net/**ListHelp<https://help.launchpad.net/ListHelp>
>
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
Mailing list: https://launchpad.net/~netstack
Post to : netstack@lists.launchpad.net
Unsubscribe : https://launchpad.net/~netstack
More help : https://help.launchpad.net/ListHelp
