On Tue, Apr 11, 2017 at 12:56:59PM EDT, Kevin J. McCarthy wrote:
> It sounds like you put some thought into it. In general, I think it's a
> good idea to preserve compatibility, so I understand why you went this
> route. However I'm still leaning towards making the options independent
> in this case. I think if we're going to split it out, we might as well
> give the configurability both ways.
Sounds good to me. See attached patch.
# HG changeset patch
# User Derek Schrock <der...@lifeofadishwasher.com>
# Date 1492002833 14400
# Wed Apr 12 09:13:53 2017 -0400
# Node ID cd3b15511d60d98883f85ef930b48a060712d2a9
# Parent 29239b1a6d50c1afc571959d7207af1b26f1a256
Add option $beep_new_buffy that controls if mutt should beep for buffy
notifications.
- Make beep_new and beep_new_buffy independent of each other.
diff -r 29239b1a6d50 -r cd3b15511d60 UPDATING
--- a/UPDATING Sat Apr 08 14:21:15 2017 -0700
+++ b/UPDATING Wed Apr 12 09:13:53 2017 -0400
@@ -8,6 +8,11 @@
The keys used are:
!: modified feature, -: deleted feature, +: new feature
+default (unreleased):
+
+ ! option $beep_new only beeps for new mail from currently open mailbox.
+ + option $beep_new_buffy controls if mutt beeps for buffy notificatons.
+
1.8.0 (2017-02-24):
- $locale has been removed. Mutt now respects the LC_TIME setting
diff -r 29239b1a6d50 -r cd3b15511d60 curs_main.c
--- a/curs_main.c Sat Apr 08 14:21:15 2017 -0700
+++ b/curs_main.c Wed Apr 12 09:13:53 2017 -0400
@@ -656,7 +656,7 @@
if (mutt_buffy_notify())
{
menu->redraw |= REDRAW_STATUS;
- if (option (OPTBEEPNEW))
+ if (option (OPTBEEPNEWBUFFY))
beep();
}
}
diff -r 29239b1a6d50 -r cd3b15511d60 init.h
--- a/init.h Sat Apr 08 14:21:15 2017 -0700
+++ b/init.h Wed Apr 12 09:13:53 2017 -0400
@@ -313,8 +313,15 @@
/*
** .pp
** When this variable is \fIset\fP, mutt will beep whenever it prints a
message
- ** notifying you of new mail. This is independent of the setting of the
- ** $$beep variable.
+ ** notifying you of new mail from the currently open mailbox. This is
independent
+ ** of the setting of the $$beep variable.
+ */
+ { "beep_new_buffy", DT_BOOL, R_NONE, OPTBEEPNEWBUFFY, 0 },
+ /*
+ ** .pp
+ ** When this variable is \fIset\fP, mutt will beep whenever it prints a
message
+ ** notifying you of new mail from a buffy mailbox (see ``$mailboxes'').
This is
+ ** independent of the setting of the $$beep variable.
*/
{ "bounce", DT_QUAD, R_NONE, OPT_BOUNCE, MUTT_ASKYES },
/*
diff -r 29239b1a6d50 -r cd3b15511d60 mutt.h
--- a/mutt.h Sat Apr 08 14:21:15 2017 -0700
+++ b/mutt.h Wed Apr 12 09:13:53 2017 -0400
@@ -338,6 +338,7 @@
OPTAUTOTAG,
OPTBEEP,
OPTBEEPNEW,
+ OPTBEEPNEWBUFFY,
OPTBOUNCEDELIVERED,
OPTBRAILLEFRIENDLY,
OPTCHECKMBOXSIZE,
