On Mon, Apr 10, 2017 at 01:43:46PM -0400, Derek Schrock wrote: > I could see where users would want to $beep_new off and $beep_new_buffy > however if you don't mind breaking functionality then I guess it's > alright and the default value should be 0 for $beep_new_buffy and the > check for $beep_new should be removed for buffy notifications beep > checking.
It sounds like you put some thought into it. In general, I think it's a good idea to preserve compatibility, so I understand why you went this route. However I'm still leaning towards making the options independent in this case. I think if we're going to split it out, we might as well give the configurability both ways. > If you were to take it a couple extra steps further could you have > $beep_new for currently open box, $beep_new_buffy be a list of mailboxes > from mailboxes such that you want notifications/beeps from? I think this would be too much work, not to mention the complications when a mailbox listed in beep_new_buffy is not even polled by 'mailboxes'. Let's just keep the binary option and have a single command (mailboxes) for polling mailboxes. -- Kevin J. McCarthy GPG Fingerprint: 8975 A9B3 3AA3 7910 385C 5308 ADEF 7684 8031 6BDA
signature.asc
Description: PGP signature