On Mon, Apr 10, 2017 at 12:21:56PM EDT, Kevin J. McCarthy wrote: > On Sun, Apr 09, 2017 at 02:58:44PM -0400, Derek Schrock wrote: > > Add option $beep_new_buffy that controls if mutt should beep for buffy > > notifications. > > Ordinarily I'm not a fan of "micro-options" like this. However, beeps > annoy me to the extent that I can understand the desire to control when > they occur more precisely. > > One concern is that the behavior of $beep_new is now less clear unless > you look at the code. I think its documentation should be revised to > state that it will beep when new mail arrives in the currently open > mailbox. > > My other concern is whether this new option should be predicated on the > $beep_new option. Does it make sense to want to beep for buffy > notifications, but not for the currently open mailbox?
The above is exactly what I thought when writing this patch. $beep_new would be a global on/off switch for any beeping and in order of any micro-option to work $beep_new would have to be turned on hence the comment in the $beep_new_buffy. I wanted to keep existing functionality the same without disabling/enabling beeps. Like you I want to limit the number of beeps and didn't want this to cause pain for others. I felt that if you're opting into $beep_new then you would have the inclination to find any extra beep options. I could see where users would want to $beep_new off and $beep_new_buffy however if you don't mind breaking functionality then I guess it's alright and the default value should be 0 for $beep_new_buffy and the check for $beep_new should be removed for buffy notifications beep checking. If you were to take it a couple extra steps further could you have $beep_new for currently open box, $beep_new_buffy be a list of mailboxes from mailboxes such that you want notifications/beeps from? set beep_new_buffy = * # All mailboxes in mailboxes beep set beep_new_buffy = boxA, boxB, boxZ # Beep when A, B, Z are updated. If the above idea is a little too much then a on/off for current and on/off for buffy seems reasonable and don't mind breaking existing functionality I can provide another patch. Otherwise if a global on/off ($beep_new) is better then a small update to the $beep_new comment should include "... currently open mailbox ..."
