-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/07/2011 07:16 AM, Brian Paul wrote: > On 03/05/2011 09:26 PM, Marek Olšák wrote: >> RenderTexture doesn't have to be called in invalidate_rb, I guess. >> --- > > The patch looks good but there's one simple optimization that could be > made. If glRenderBufferStorage() is called with a new width/height but > the internalFormat stays the same, we wouldn't have to invalidate the > parent FBO(s). > > I think changing the size of a renderbuffer would be more common than > channging its format.
That's only true if the driver supports ARB_fbo. With EXT_fbo a framebuffer is incomplete if the attachments have mismatched sizes. This is one of the error conditions that was removed in the ARB version. There any drivers that support EXT_fbo and not ARB_fbo? If there are, can we fix them? :) This would allow some other code cleanups as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk11UkUACgkQX1gOwKyEAw+AqwCgn2ddst1Lzlt97Fz0P/ZZFRdE iawAnR9lq8p8elC1fDrVkLhvrxBrBReV =wh2N -----END PGP SIGNATURE----- _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
