Enrico Forestieri wrote:
On Mon, Oct 16, 2006 at 12:22:22AM +0200, Enrico Forestieri wrote:
On Sat, Oct 14, 2006 at 10:45:52AM +0200, Georg Baum wrote:
But you can do a binary search for revisions that
work and that don't in order to find out which patch is the culprit.
The culprit turned out to be changeset 15265:
http://www.lyx.org/trac/changeset/15265
Until revision 15264 everything is fine. After 15265 the qt3 frontend
can be compiled only with changeset 15271 and the problem appears.
However, the patches in between do not seem to be relevant.
The problem here is that a string iterator has type "pointer to char",
which by default is signed on Cygwin. So, the ascent() functions was
being passed an unresonably large (and wrong) value for nonascii chars.
The solution here is to convert to unsigned char before calling ascent()
and descent().
With the attached patch I don't get crashes anymore. I will commit it
shortly if nobody objects.
Hum, no objection but a more correct fix would have been to convert to
unicode.
Abdel.
