aadsm marked an inline comment as done.
aadsm added inline comments.
================
Comment at:
lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:549-550
- if (ModuleSP module_sp = target.GetOrCreateModule(module_spec,
- true /* notify */)) {
+ if (ModuleSP module_sp =
+ target.GetOrCreateModule(module_spec, true /* notify */)) {
UpdateLoadedSections(module_sp, LLDB_INVALID_ADDRESS, m_interpreter_base,
----------------
aadsm wrote:
> labath wrote:
> > Whitespace-only change. Did you maybe run clang-format on the whole file
> > instead of just the diff?
> >
> > It doesn't matter that much here as there isn't many of them, but I just
> > want to make sure you're aware of this in the future.
> odd, pretty sure I just run clang-format-diff (as I don't have auto
> formatting going on), will double check this.
I have my editor to remove trailing spaces on save and this line had one,
that's why it ended up being parsed by clang-format-diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62500/new/
https://reviews.llvm.org/D62500
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
