aadsm marked 2 inline comments as done.
aadsm added inline comments.
================
Comment at: lldb/source/Plugins/Process/Utility/AuxVector.cpp:11
-using namespace lldb;
-using namespace lldb_private;
+AuxVector::AuxVector(lldb_private::DataExtractor &data) { ParseAuxv(data); }
----------------
clayborg wrote:
> Not a big fan of constructors doing parsing work. No way to return an error
> unless you build that into the AuxVector class (AuxVector::GetError()).
That is true but ParseAuxv doesn't generate errors. It just reads as much data
as it exists in the data extractor until there's no more.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62500/new/
https://reviews.llvm.org/D62500
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
