aadsm marked an inline comment as done. aadsm added inline comments.
================ Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:183 + m_process->GetAddressByteSize()); + m_auxv = llvm::make_unique<AuxVector>(auxv_data); ---------------- clayborg wrote: > Use std::move? > ``` > m_auxv = llvm::make_unique<AuxVector>(std::move(auxv_data)); > ``` The constructor receives a `lldb_private::DataExtractor &` so there's no copy going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits