clayborg added inline comments.
================ Comment at: lldb/source/Plugins/Process/Utility/ELFAuxVector.cpp:18 + lldb::offset_t saved_offset = *offset_ptr; + *value = data.GetMaxU64(offset_ptr, data.GetAddressByteSize()); + return *offset_ptr != saved_offset; ---------------- aadsm wrote: > clayborg wrote: > > ``` > > data.GetAddress(offset_ptr); > > ``` > I know you pointed this out but I felt weird calling `GetAddress` since > that's not the semantic value of the underlying data. That's why I still > ended up with GetMaxU64, what do you think? I would use it since that is exactly what you are doing with "data.GetMaxU64(offset_ptr, data.GetAddressByteSize());". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62500/new/ https://reviews.llvm.org/D62500 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
